Skip to content

Add: typing section to docstring page in guide #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2023

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Apr 5, 2023

No description provided.

@lwasser lwasser force-pushed the SimonMolinsky-main branch from 36ebbd0 to a099675 Compare April 5, 2023 13:20
@lwasser lwasser force-pushed the SimonMolinsky-main branch from a099675 to 74796ee Compare April 5, 2023 13:24
Update documentation/write-user-documentation/document-your-code-api-docstrings.md

Update documentation/write-user-documentation/document-your-code-api-docstrings.md

Update documentation/write-user-documentation/document-your-code-api-docstrings.md

Update documentation/write-user-documentation/document-your-code-api-docstrings.md

Update documentation/write-user-documentation/document-your-code-api-docstrings.md

Edits to type hint section
@lwasser lwasser force-pushed the SimonMolinsky-main branch from 74796ee to b17a76f Compare April 5, 2023 13:28
@lwasser lwasser changed the title Refactor of simon's pr on typing Add: typing section to docstring page in guide Apr 5, 2023
Copy link
Contributor

@SimonMolinsky SimonMolinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything is ok in here, I see that you have done some editing and cleaning of the content. I like that it is less wordy and stricter 👍 Thank you! 🙇

@lwasser
Copy link
Member Author

lwasser commented Apr 11, 2023

ok great @SimonMolinsky thank you. yes i just thought what you added was so good but it didn't match the content on the rest of the page. so i pulled a small section out and then i pulled the rest into a tutorial for our website!! i'll go ahead and merge this and then we can work on the tutorial if that sounds ok to you?

@lwasser lwasser merged commit 452ac67 into pyOpenSci:main Apr 11, 2023
@lwasser
Copy link
Member Author

lwasser commented Apr 11, 2023

if you'd like to make additional changes feel free to just open a new pr!! many thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants