Skip to content

docs: Add ruff section in code style page #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

Batalex
Copy link
Collaborator

@Batalex Batalex commented Aug 3, 2023

I think we should add basic configurations for flake8 and isort to be compatible with black.

  • Isort is easy: profile = black
  • Flake8 is trickier: rules E203, E501 and W503 need to be excluded

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Batalex this looks awesome! i made a few comments that are very minor - my thought it to just remove blue and add Ruff here to keep decision making simple. :) but let me know what your thoughts are!

Batalex and others added 2 commits August 3, 2023 16:57
Co-authored-by: Leah Wasser <[email protected]>
@lwasser
Copy link
Member

lwasser commented Aug 3, 2023

@Batalex how do you feel about having more superpowers for this repo? so you could merge and review prs and such?

@Batalex
Copy link
Collaborator Author

Batalex commented Aug 3, 2023

@Batalex how do you feel about having more superpowers for this repo? so you could merge and review prs and such?

Yeaaay, unlimited power

@lwasser
Copy link
Member

lwasser commented Aug 3, 2023

sweeeeet!! ok i'l gonna give you super powers. let's also get this merged!

@lwasser
Copy link
Member

lwasser commented Aug 3, 2023

only failing build because of a 500 error for conda-forge - the link works. so we can merge

@lwasser lwasser merged commit 3441de2 into pyOpenSci:main Aug 3, 2023
@Batalex Batalex deleted the docs/add-ruff branch August 4, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants