Virtual function dispatch has problems with similar-named functions

[bennybp]

I am unable to call a virtual function (implemented in python) from that virtual function in another object. It looks like there is code in get_overload that compares function names and returns a null function if it matches. I suppose this was added to prevent infinite looping (?), but results in false positives.

Small example: Cpp File:

#include <iostream>
#include <pybind11/pybind11.h>

struct Base {
    virtual void Print(void) const = 0;
};

struct PyClass {

    virtual void Print(void) const {
        PYBIND11_OVERLOAD_PURE(
            void,
            Base,
            Print
        );
    }
};

void CallPrint(const Base * b) { b->Print(); }

PYBIND11_PLUGIN(mytest)
{
    pybind11::module m("mytest", "A test");

    pybind11::class_<PyClass> base(m, "Base");
    base.alias<Base>()
        .def(pybind11::init<>())
        .def("Print", &Base::Print);

    m.def("CallPrint", &CallPrint);

    return m.ptr();
}

Python:

import mytest as my

class PyClass1(my.Base):
  def __init__(self):
    my.Base.__init__(self)

  def Print(self):
    print("In PyClass1")


class PyClass2(my.Base):
  def __init__(self):
    my.Base.__init__(self)

  def Print(self):
    print("In PyClass2")
    p = PyClass1()
    my.CallPrint(p)  # <<< Problem here

b = PyClass2()
my.CallPrint(b)

Error is RuntimeError: Tried to call pure virtual function "Print"