pybind11Tools: Use interface target library when able #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricCousineau-TRI
force-pushed
the
feature/pybind11_tools_use_interface_library
branch
from
865f900 to
124e651
Compare
EricCousineau-TRI
force-pushed
the
feature/pybind11_tools_use_interface_library
branch
2 times, most recently
from
a421b9b to
cd453ef
Compare
EricCousineau-TRI
added a commit
to RobotLocomotion/pybind11
that referenced
this pull request
May 24, 2018
…pr_1373_1367 Merge pybind#1367 and pybind#1373
19 tasks
|
Fixed as part of the CMake refactor. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be nice if the interface target libraries were used via
pybind11_add_module.\cc @jamiesnape