Skip to content

Enable dynamic attribute support for Pypy >= 6 #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

inducer
Copy link
Contributor

@inducer inducer commented Aug 19, 2018

According to my experiments, the code that's disabled by the conditional on Pypy appears to work just fine on (at least) Pypy 6.0.

@wjakob
Copy link
Member

wjakob commented Aug 28, 2018

I'm hesitant to merge this if there is no test coverage. Would you mind adding a PyPy 6.x configuration to Travis?

@inducer
Copy link
Contributor Author

inducer commented Aug 28, 2018

Done. It does not pass, but the failures look largely unrelated to the change I made:

https://travis-ci.org/pybind/pybind11/jobs/421779974

@bstaletic
Copy link
Collaborator

Rebase onto master. The failure was fixed last night.

@inducer
Copy link
Contributor Author

inducer commented Aug 29, 2018

Thanks for taking a look. Still failing, with much the same failures:

https://travis-ci.org/pybind/pybind11/jobs/421907230

@wjakob
Copy link
Member

wjakob commented Sep 11, 2018

hm :-| -- any thoughts on what the deal is with the other PyPy issue?

@inducer
Copy link
Contributor Author

inducer commented Sep 11, 2018

No clue, sorry.

@xuhdev
Copy link

xuhdev commented Sep 19, 2018

Do you have any actual reference that PyPy 6 has this enabled?

@wjakob
Copy link
Member

wjakob commented Sep 19, 2018

Not sure I understand, what does "this" refer to in your sentence? Attribute support?

@xuhdev
Copy link

xuhdev commented Sep 19, 2018

@wjakob Yes... sorry for the confusion.

lopuhin added a commit to lopuhin/pybind11 that referenced this pull request Mar 3, 2019
lopuhin added a commit to lopuhin/pybind11 that referenced this pull request Mar 8, 2019
lopuhin added a commit to lopuhin/pybind11 that referenced this pull request Mar 8, 2019
lopuhin added a commit to lopuhin/pybind11 that referenced this pull request Mar 8, 2019
@isuruf isuruf mentioned this pull request Mar 26, 2020
2 tasks
@rwgk
Copy link
Collaborator

rwgk commented Jun 18, 2020

Hi Andreas, there was a recent upgrade to use PyPy 7.3 on travis, e.g. here is a random recent result (bottom of page): https://travis-ci.org/github/pybind/pybind11/builds/698654908
Is this PR still relevant?

@lopuhin
Copy link

lopuhin commented Jun 18, 2020

@rwgk I think this PR is still relevant and now it seems closer to merging (after travis changes are removed), as these changes https://github.com/pybind/pybind11/pull/1494/files#diff-cb87ad4a7288c536c9adc5a5694134ca still look relevant to me.

@inducer
Copy link
Contributor Author

inducer commented Jun 18, 2020

IMO, #2146 by @isuruf supersedes this. I contains this change (and adds a related test). I'm happy to close this as long as there's a chance that #2146 will get merged.

@wjakob
Copy link
Member

wjakob commented Jun 30, 2020

It will be merged soon, I will close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants