Add support for Cygwin #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Boris, thank you for the Cygwin fixes. There were some conflicts with another (big!) PR: #207, which I tried to resolve. Please let me know if I broke something. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 64-bit version of Cygwin defines PyThread_create_key() with a return type of long (instead of int; some background information can be found on the cygwin-apps mailing list). This pull request makes pybind11 use decltype() to deduce the type to use for pybind11::detail::internals::tstate. I also added the flag -Wconversion to CMakeLists.txt to help detect this kind of problems in the future.
I tested pybind11 with the changes on Cygwin (only 64-bit version), Linux (g++) and Windows (VS2015).