Improve finding python with cmake >= 3.12.0 #2156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, it appears that cmake 3.12.4 was broken again (i'm currenly using cmake 3.17.0) So I close this for now, check the various versions and resubmit when I got the proper version determined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
With this change, during setup, cmake uses the new "Python" cmake module instead of the old "PythonInterp" if the cmake version is >= 3.12.0. This has the advantage of properly detecting python3 even on systems where both python2 and python3 are installed and python2 preceedes python3 in the PATH environment variable.
I have the above situation here, and therefore would appreciate if you could merge that. It also applies to v.2.5 without changes.
Cheers
-Fritz