Skip to content

fix: some build-system cleanup #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 6, 2020
Merged

fix: some build-system cleanup #2368

merged 5 commits into from
Aug 6, 2020

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Aug 6, 2020 •
edited
Loading

Taking the unrelated changes from #2353 to see if that can go in stand alone.

  • Some cleanup of CMakeLists
  • Make all target names unique
  • Include .cmake.in files when formatting
  • Update CI to do more testing (shorten Configure to Config, too)
  • PYBIND11_CPP_STANDARD was not being handled correctly, now it does what I claimed it did before

@henryiii henryiii changed the title fix: partial cleanup fix: some build-system cleanup Aug 6, 2020
rwgk
rwgk approved these changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big Thank You Henry!

@henryiii henryiii merged commit 227170d into pybind:master Aug 6, 2020
@henryiii henryiii deleted the tests/pclean branch August 6, 2020 15:54
@MonkeyBreaker MonkeyBreaker mentioned this pull request Aug 8, 2020
Closed
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

Assignees
No one assigned
Labels
build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @rwgk