Using recently added pytest.PY2 instead of str is bytes.#2396
Merged
EricCousineau-TRI merged 1 commit intopybind:masterfrom Aug 14, 2020
Merged
Using recently added pytest.PY2 instead of str is bytes.#2396EricCousineau-TRI merged 1 commit intopybind:masterfrom
pytest.PY2 instead of str is bytes.#2396EricCousineau-TRI merged 1 commit intopybind:masterfrom
Conversation
Important gain: uniformity & therefore easier cleanup when we drop PY2 support. Very slight loss: it was nice to have `str is bytes` as a reminder in this specific context.
Collaborator
|
Failure here is for Python 3.9-dev on macOS: I say this is good to merge, as the failure is unrelated to this PR? |
Collaborator
|
I'ma go ahead and pull the "merge" trigger. |
Collaborator
Author
|
Awesome, thanks Eric! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important gain: uniformity & therefore easier cleanup when we drop PY2 support.
Very slight loss: it was nice to have
str is bytesas a reminder in this specific context.