Add check if str(handle) correctly converted the object, and throw py::error_already_set if not (bis)
#2477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py::error_already_set if not
|
@rwgk, yes, you were right in #2473: it is messy to get the old commits, since they are more intertwined with the other fixes. Apologies, #2473 should not per se have been closed, because I'm now ending up with basically the same PR. But here we are, anyway. Since this already passed review, go ahead and merge this (I think it's the same as you had, except that I referred to the chimera-PR and left the intended test in place). |
YannickJadoul
changed the title
str(handle) correctly converted the object, and throw py::error_already_set if not (bis)
4 tasks
rwgk
approved these changes
Sep 10, 2020
YannickJadoul
force-pushed
the
fix-python2-str-malformed_utf8
branch
from
76f3ebe to
055f86f
Compare
|
Awesome @YannickJadoul, thanks for merging! |
|
Thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2392, already reviewed and merged into
str-bytes-cleanup.This are just the original commits cherry-picked, plus one additional fix to the tests (since #2380 is on
str-bytes-cleanupbut not onmasteryet).