Stop py::array_t arguments from accepting arrays that do not match the C- or F-contiguity flags

[YannickJadoul]

noconvert checks for py::array_t whether the passed type is compatible, but it doesn't check whether the array::c_style or array::f_style flags are satisifed. See #2455 for a demonstration.

Closes #2455

[henryiii]

Looks great to me. I like the new test. 👍

[YannickJadoul]

Looks great to me. I like the new test. 👍

Thanks! I despise the size/complexity of the test, myself 😄 But at least we know it should be quite safe to merge.

I'll wait a bit longer if anyone else has something to say, and if we get no further complaints, I'll merge :-)

[wjakob]

I vaguely remember running into this annoying issue myself. Fix and test look all good to me.

[YannickJadoul]

Thanks! :-)

[aldanor]

That's nice! Worth releasing 2.6.0 with this feature perhaps? (it's been a while since 2.5.0 anyway)

[henryiii]

There are quite a few things in 2.6.0 :) I think we need a bit more time to make sure the latest changes (especially the setup.py rework) are nice and stable and useful before we release. I don't think it's too far away, though.