Skip to content

fix: use OVERRIDE instead of OVERLOAD #2490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Conversation

henryiii
Copy link
Collaborator

@YannickJadoul, I undid a few changes from #2325 in #2478 due to a bad rebase (I had the change backwards for some reason). This should fix it, I think.

Copy link
Collaborator

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :-)

@henryiii
Copy link
Collaborator Author

Okay, one of us can merge when tests pass. ;)

@YannickJadoul YannickJadoul mentioned this pull request Sep 15, 2020
@YannickJadoul
Copy link
Collaborator

Thanks for the docs fix!

@henryiii henryiii merged commit dabbbf3 into pybind:master Sep 15, 2020
@henryiii henryiii deleted the fix/rebase branch September 15, 2020 16:10
@NickAlger
Copy link

FYI, the default version installed using conda still uses OVERLOAD. At present, anyone who installs pybind11 via conda will get an error when they try to follow this tutorial (this happened to me, leading to several hours of confusion before I found this thread)

@YannickJadoul
Copy link
Collaborator

@NickAlger, what's the version you get from conda, then?

@YannickJadoul
Copy link
Collaborator

@NickAlger, I downloaded a random package from here, and it does contain the correct 2.6.0 files. Now I'm very curious where you got your version.

@NickAlger
Copy link

@YannickJadoul Looks like 2.4.3, installed 3 days ago via
conda install -c conda-forge pybind11
But looking into it further, it seems like conda decided to install version 2.4.3 for compatibility with some other package in the environment (fenics). Using a new conda environment installs 2.6.0

@YannickJadoul
Copy link
Collaborator

@NickAlger, that's quite horrible; quite a few things have been improved since 2.4.3. Anyway, thanks for looking into that! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants