-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: use OVERRIDE instead of OVERLOAD #2490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :-)
Okay, one of us can merge when tests pass. ;) |
Thanks for the docs fix! |
FYI, the default version installed using conda still uses OVERLOAD. At present, anyone who installs pybind11 via conda will get an error when they try to follow this tutorial (this happened to me, leading to several hours of confusion before I found this thread) |
@NickAlger, what's the version you get from conda, then? |
@NickAlger, I downloaded a random package from here, and it does contain the correct 2.6.0 files. Now I'm very curious where you got your version. |
@YannickJadoul Looks like 2.4.3, installed 3 days ago via |
@NickAlger, that's quite horrible; quite a few things have been improved since 2.4.3. Anyway, thanks for looking into that! :-) |
@YannickJadoul, I undid a few changes from #2325 in #2478 due to a bad rebase (I had the change backwards for some reason). This should fix it, I think.