Skip to content

docs: installing section #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2020
Merged

docs: installing section #2494

merged 2 commits into from
Sep 17, 2020

Conversation

henryiii
Copy link
Collaborator

This creates an installing section.

Closes #1203.

bstaletic
bstaletic approved these changes Sep 16, 2020
View reviewed changes
Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thought. Is there a reason to consider brew special enough to mention it explicitly? Linux distros all come with some sort of a package manager and at least the rolling release distros keep up with the stable releases.

@henryiii
Copy link
Collaborator Author

henryiii commented Sep 16, 2020 •
edited
Loading

Brew is the (by far) most popular macOS package manager, and it updates regularly (hours to days after releases). It also works (as Linuxbrew) on all flavors of Linux, unlike system package managers. At least one pybind11 maintainer (me) is also a regular contributor to homebrew, and will help keep up this package if it falls behind. It's also mentioned in the original issue three years ago. :)

@henryiii henryiii force-pushed the docs/install branch 2 times, most recently from c67b25c to 6e14f61 Compare September 16, 2020 20:24
wjakob
wjakob approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@wjakob wjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment.

@henryiii henryiii merged commit dec33c2 into pybind:master Sep 17, 2020
@henryiii henryiii deleted the docs/install branch September 17, 2020 00:00
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjakob wjakob wjakob approved these changes

@bstaletic bstaletic bstaletic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation contains nothing about downloading and installation
3 participants
@henryiii @wjakob @bstaletic