Skip to content

Documenting that the order of alternatives for variant types matters, and follows the same rules as overload resolution #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

YannickJadoul
Copy link
Collaborator

Description

This issue keeps coming back (#2775), even though it has been answered before (#1625, and who knows where else).

Suggested changelog entry:

Just docs. No need for a changelog entry, I think.

… and follows the same rules as overload resolution
@YannickJadoul
Copy link
Collaborator Author

Note: should we disable the 10-dev builds for now, while we wait for resolution of #2774?

@bstaletic
Copy link
Collaborator

I've asked multiple times before, but here goes...

Should we close all currently open issues that come down to "specified overload order matters"?

@YannickJadoul
Copy link
Collaborator Author

Should we close all currently open issues that come down to "specified overload order matters"?

Are there still any open?

Also, this PR is just for variant. Function overloads have been documented for ages, now.

@henryiii henryiii merged commit 1faf4a8 into pybind:master Jan 14, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jan 14, 2021
@YannickJadoul YannickJadoul deleted the variant-resolution branch January 14, 2021 09:41
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants