Skip to content

Disable builds for 3.10.0a4, and enable a nightly 3.10-dev build #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 14, 2021

Conversation

YannickJadoul
Copy link
Collaborator

Description

Temporary fix for #2774. Meanwhile, this also adds 3.10-dev nightly builds from deadsnakes.

@YannickJadoul
Copy link
Collaborator Author

@henryiii, this seems to be working. But I'm not sure the nightly Python versions are really worth the extra complexity (and additional almost-never-executed "Setup Python X.Y (nightly)" step). Maybe it should be a separate matrix of jobs, where we also test some debug versions? I don't know.

At any rate, feel free to push to this branch to propose changes :-)

@YannickJadoul
Copy link
Collaborator Author

@henryiii, this seems to be working.

Neeeeeeeeevermind that. Why can't it find the correct Python? :-(

@henryiii
Copy link
Collaborator

henryiii commented Jan 13, 2021

I'd add a new job at least, I think. Or maybe not, this is not that inelegant. A dev only set might be not unreasonable.

@YannickJadoul YannickJadoul force-pushed the disable-3.10-dev branch 2 times, most recently from 08e27aa to b1f05ee Compare January 13, 2021 22:15
@YannickJadoul
Copy link
Collaborator Author

Heh...

Run deadsnakes/[email protected]
  with:
    python-version: 3.10-dev
    debug: false

And yet 10-dev is still acting as if debug was specified. I might need to fix my own PR deadsnakes/action#18

@YannickJadoul
Copy link
Collaborator Author

Submitted a fix: deadsnakes/action#20

@henryiii, if you want to merge this before deadsnakes/action#20 would be merged, that's possible. Either as-is (with my branch, temporarily), or without the last commit (which will install the 3.10-dev debug version, but eh, should be fine).

@YannickJadoul
Copy link
Collaborator Author

@henryiii, if you want to merge this before deadsnakes/action#20 would be merged, that's possible. Either as-is (with my branch, temporarily), or without the last commit (which will install the 3.10-dev debug version, but eh, should be fine).

That went fast. Scratch that, the PR already got merged, and a new release released :-)

Python 2.7 doesn't work with deadsnakes/action (because there's no python2.7-venv package, and no venv), but ... well let's cross that bridge (and make that PR) when we need to?

@henryiii henryiii merged commit f243450 into pybind:master Jan 14, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jan 14, 2021
@YannickJadoul YannickJadoul deleted the disable-3.10-dev branch January 14, 2021 09:42
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants