-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: get PyPy 3.7 wheels using NumPy 1.20 #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If we have expected warnings, they need to be wrapped in a pytest warns block.
anyway, the Intel failure is just an infrastructure failure. The vagrind one seems to be a multi threading failure? |
The warnings are a reminder that we still need to further clean up int casters. I had them ignored, but basically, they are a consequence of calling |
If they are in a warns block, I can grep for warns blocks. Maybe add a TODO or FIXME comment. I don't think we should have unhandled warnings in our tests. I originally thought it was an issue with the changes in NumPy 1.20. |
Any idea why (just) the valgrind job is failing with NumPy 1.20? All Pythons 3.7-3.9 are getting 1.20 now. |
Because the suppressions in |
Yep, but there's no "expected warning" thing, like with expected errors? Also, those warnings have been there for a long time, so I don'tt feel like just shutting them up was the right thing to do. Though maybe we should pick up the habit of turning warnings into errors, then. I don't know how long these warnings have been there (probably since we started supporting 3.8, because they're from Python >=3.8), but no one notices when builds pass. |
This ought to fix Valgrind finding leaks in the new version of NumPy. At least locally, it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (can't add the green check mark in the app?)
That's also an option, ofc. That's not filtering warnings, but asserting for them. It does say that:
If you want, I can still add that? But again, we've had these warnings for ages, I believe. (All old logs have expired, though; just checked.) |
Done in #2838. Let's not care about that for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge if you want, @henryiii.
Description
PyPy 3.7 wheels are included with NumPy 1.20. But not 3.6 since they've dropped 3.6 support.
Suggested changelog entry:
Just tests.