Adding virtual_overrider_self_life_support. #2902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables safely passing
unique_ptr
from Python to C++, even for trampolines.A disowned trampoline Python object is kept it alive until the
unique_ptr
pointee is destroyed. The critical small trick needed was found in PyCLIF (probably invented by @mrovner):google/clif@acacae6
The critical part of the trick is: the
Py_INCREF
is triggered only when the trampoline Python object is in the process of being disowned.This PR goes beyond PyCLIF, in that the disowned Python object still maintains a pointer that is only reset and deregistered when the
unique_ptr
pointee is deleted, which means methods of the pointee can still be safely accessed from Python. This could be viewed as "lazy disowning".