-
Notifications
You must be signed in to change notification settings - Fork 2.2k
CI for smart holders as default #2930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4876b24
to
88f3474
Compare
cmake implicitly sets |
f207165
to
2417d9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like that it's so easy, but I'm also really worried about introducing two copies of something so substantial. @henryiii, is there an obvious way to avoid the duplication?
Naive idea: have a small patch file somewhere else, and a bash script that applies that patch to generate this file, with a big comment at the top: "This is an auto-generated file, do not edit." And another comment with instructions how to run the bash script. — But I hope Henry knows of something more organized.
I tried to merge the new SH builds into the existing |
2417d9d
to
e3fa46e
Compare
The work here was included in #2963. Closing. Thanks Robert! |
This adds another CI workflow enabling
PYBIND11_USE_SMART_HOLDER_AS_DEFAULT