Adding reclaim_disowned logic & miscellaneous naming and documentation improvements. #2943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g is now reversible: reclaim_disowned).
…line_self_life_support (to reuse existing terminology instead of introducing new one).
|
The CI is green, also with @EricCousineau-TRI, @elkhrt, @rhaschke: This PR renames |
rwgk
added a commit
to google/clif
that referenced
this pull request
Apr 12, 2021
pybind/pybind11#2943 This PR was not reviewed on github, please review here. If there are requests for changes I will address them in a new PR. The main change is to add `reclaim_disowned` logic related to trampolines and `std::unique_ptr` (smart_holder_type_casters.h, smart_holder_poc.h, trampoline_self_life_support.h). A new section is added to README_smart_holder.rst: Trampolines and std::unique_ptr `py::virtual_overrider_self_life_support` is renamed to `py::trampoline_self_life_support`, to better connect to the existing documentation. third_party/clif/pybind11/generator.py is adjusted accordingly. All other changes are pure renaming to make the code a little easier to navigate. Regarding TGP: The 4 targets marked Newly Broken were inspected manually. The failures are unrelated to this CL. TESTED=TPG (http://tap/OCL:367756875:BASE:367778561:1618053415251:42db1e5c) Import pybind/pybind11 from GitHub. - 6c922614ed68dbcff6c8ee00a47550e00921533d Adding reclaim_disowned logic & miscellaneous naming and ... by Ralf W. Grosse-Kunstleve <[email protected]> PiperOrigin-RevId: 367880386
EricCousineau-TRI
added
the
smart holder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.