Skip to content

Splitting out include/pybind11/detail/pragma_warning_block.h #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 4, 2021
Merged

Splitting out include/pybind11/detail/pragma_warning_block.h #2988

merged 3 commits into from
May 4, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented May 1, 2021

Alternative to moving the pragma block to common.h. This way the code organization on master can stay exactly the same.

@rwgk rwgk requested a review from henryiii as a code owner May 1, 2021 00:06
@rwgk rwgk closed this May 1, 2021
@rwgk rwgk reopened this May 1, 2021
@rwgk rwgk mentioned this pull request May 1, 2021
Closed
@rwgk
Copy link
Collaborator Author

rwgk commented May 4, 2021

Merging to cut down on number of PRs to manage. This change is still awaiting review under #2873.

@rwgk rwgk merged commit bc3cd8a into pybind:smart_holder May 4, 2021
@rwgk rwgk deleted the sh_pragma_warning_block_h branch May 4, 2021 05:08
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 4, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 12, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii Awaiting requested review from henryiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwgk @henryiii