Changing .clang-format AlignConsecutiveAssignments to false and applying to smart_holder code.
#3065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Skylion007 did you have a suggestion for another .clang-format config change? Something to do with pointers? |
|
Yeah, there was suggestions about where to align "pointer *" and "reference &" to be part of the type instead of part of the var. |
|
I love this PR as it stands! We cool with reviewing / merging this as-is? @henryiii? |
|
Aha! I see #3067 |
Also removing a commented-out line.
rwgk
force-pushed
the
sh_clang_format_config_adj
branch
from
ed8ea12 to
0437e91
Compare
|
Ignoring the one CI flake (eigen download failed). |
|
Ouch, silly mistake: I forgot the |
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Jul 2, 2021
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Jul 2, 2021
rwgk
added a commit
that referenced
this pull request
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying new .clang-format config merged with PR #3067.
All changes are automatic (clang-format). NO manual changes.