Move object in pop method of List.#3116
Merged
Skylion007 merged 2 commits intopybind:masterfrom Jul 20, 2021
Merged
Conversation
Collaborator
|
@blacktea Seems some of the compilers aren't happy about this. |
Contributor
Author
Yep. It seems a compiler bug. |
rwgk
approved these changes
Jul 20, 2021
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
LGTM. Feeling good enough about it that it doesn't need the Google testing. (And it's small so easy to roll back in the unlikely event that something goes wrong.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest to move object because it should be deleted from vector, and move constructor likely faster than copy constructor.
BTW, If the class hasn't got a move constructor it would be copied.
Suggested changelog entry:
Move object in ``.pop()`` for list.