Limiting pragma for ignoring GCC 7 -Wnoexcept-type to the scope of pybind11.h. #3161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comment about the dicy nature of -Wnoexcept-type ("if and only if").
rwgk
changed the title
henryiii
reviewed
Jul 30, 2021
include/pybind11/pybind11.h
Outdated
Comment on lines
53
to
55
| It seems very unlikely that this warning will be useful to anyone (no other GCC version | ||
| generates it), but to be maximally accommodating we turn it off here instead of using a | ||
| command line option. |
There was a problem hiding this comment.
other GCC version generates it
🤣
Suggested change
| It seems very unlikely that this warning will be useful to anyone (no other GCC version | |
| generates it), but to be maximally accommodating we turn it off here instead of using a | |
| command line option. | |
| No other GCC version generates this warning. |
Too much information, we want pybind11 to compile out of the box with no warnings if possible, and that's why we carefully remove a few warnings, including this one.
There was a problem hiding this comment.
Change applied. Thanks!
henryiii
approved these changes
Jul 30, 2021
|
Thanks Henry! The one failing CI job is a test_iostream flake. Safe to ignore, especially because it worked in the previous CI run and the only change was to a comment. |
henryiii
pushed a commit
that referenced
this pull request
Jul 30, 2021
…bind11.h. (#3161) * Moving pragma for ignoring -Wnoexcept-type to the one location where it is needed. * Trying a second location. * The previous commit worked (GitHub Actions green), but see the added comment about the dicy nature of -Wnoexcept-type ("if and only if"). * Applying reviewer suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to PR #3127, based on results obtained under PR #3125.
Note that the pragma for
-Wnoexcept-typeis moved from above to below all#includes. This unblocks refactoring and IWYU cleanup (and eventually merging the smart_holder branch).It is somewhat of a coincidence that the moved pragma is still in the same header file. Potentially, the pragma for
-Wnoexcept-typemay need to be copied to refactored header files, but that's the price we have to pay for improved code organization with the added requirement to not suppress warnings from the command line (for portability).The suggested changelog entry will be in the final PR of this cleanup series.
Worksheet