Skip to content

Fix test case with __new__ #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Sep 20, 2021

Description

I just realized we may not need to use ptr now that I switched to the new init style and I am testing if that is the case. Fixes minor typing bug in #3265

@Skylion007 Skylion007 closed this Sep 20, 2021
@Skylion007 Skylion007 reopened this Sep 20, 2021
@Skylion007 Skylion007 closed this Sep 20, 2021
@Skylion007 Skylion007 reopened this Sep 20, 2021
@Skylion007 Skylion007 marked this pull request as ready for review September 20, 2021 20:01
@Skylion007 Skylion007 merged commit 6e6975e into pybind:master Sep 20, 2021
@Skylion007 Skylion007 deleted the test_new_with_ref branch September 20, 2021 20:03
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Sep 20, 2021
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants