Docs: No Strip in Debug #3779
Merged
Docs: No Strip in Debug #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs were not 100% the same as we advertise with our tooling function: most users do not want to strip symbols in Debug builds.
Skylion007
approved these changes
Mar 5, 2022
|
No, I mean I just copied what we do in *Tools.cmake
|
|
@henryiii does this clarify things? :) |
|
We have to support CMake 3.4+ in our code. But 3.9+ can use We probably should include those generators in our code too, thinking about it... |
|
Agreed as a follow-up. Currently this just documents what we do already :) |
rwgk
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Mar 18, 2022
The docs were not 100% the same as we advertise with our tooling function: most users do not want to strip symbols in Debug builds.
henryiii
pushed a commit
to henryiii/pybind11
that referenced
this pull request
Mar 25, 2022
The docs were not 100% the same as we advertise with our tooling function: most users do not want to strip symbols in Debug builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docs were not 100% the same as we advertise and do with our high-level tooling function: most users do not want to strip symbols in Debug builds.
Suggested changelog entry:
* compilation documentation: guard ``pybind11_strip`` to keep symbols in debug builds