Skip to content

Scratch PR for reducing PyPy issue observed under #4246 #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Scratch PR for reducing PyPy issue observed under #4246 #4268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4d077ec
pybind11/pytypes.h `inc_ref()`, `dec_ref()` `PyGILState_Check()` **ex…
rwgk Oct 17, 2022
3cc9171
Disable `PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF` for PyPy under Windows.
rwgk Oct 17, 2022
8983383
Strip down ci.yml to only test pypy-3.9 windows-2022 test_gil_scoped.cpp
rwgk Oct 21, 2022
118eff9
Disable appveyor
rwgk Oct 21, 2022
2b546d1
Disable appveyor attempt 2
rwgk Oct 21, 2022
35d9beb
Remove all .yml files except ci.yml
rwgk Oct 21, 2022
55c4ea1
Remove all PYBIND11_TEST_FILES except test_exceptions, test_gil_scoped
rwgk Oct 21, 2022
3183d56
Revert "Remove all PYBIND11_TEST_FILES except test_exceptions, test_g…
rwgk Oct 21, 2022
910e3ae
Remove `-DPYBIND11_TEST_FILTER="test_gil_scoped.cpp"`
rwgk Oct 21, 2022
87c57ed
Forgot to remove the `defined(PYPY_VERSION) && defined(_MSC_VER)` con…
rwgk Oct 21, 2022
cac15e8
Revert "Revert "Remove all PYBIND11_TEST_FILES except test_exceptions…
rwgk Oct 21, 2022
d91a558
Revert "Disable appveyor attempt 2"
rwgk Oct 21, 2022
5d3652e
Revert "Disable appveyor"
rwgk Oct 21, 2022
96206b5
Remove all but `test_cross_module_gil()` from test_gil_scoped.py
rwgk Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
884 changes: 3 additions & 881 deletions .github/workflows/ci.yml
View file
Open in desktop

Large diffs are not rendered by default.

80 changes: 0 additions & 80 deletions .github/workflows/configure.yml
View file
Open in desktop

This file was deleted.

55 changes: 0 additions & 55 deletions .github/workflows/format.yml
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions .github/workflows/labeler.yml
View file
Open in desktop

This file was deleted.

110 changes: 0 additions & 110 deletions .github/workflows/pip.yml
View file
Open in desktop

This file was deleted.

112 changes: 0 additions & 112 deletions .github/workflows/upstream.yml
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions include/pybind11/detail/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,12 @@
# endif
#endif

// See description of PR #4246:
#if !defined(NDEBUG) && !defined(PY_ASSERT_GIL_HELD_INCREF_DECREF) \
&& !defined(PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF)
# define PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF
#endif

// #define PYBIND11_STR_LEGACY_PERMISSIVE
// If DEFINED, pybind11::str can hold PyUnicodeObject or PyBytesObject
// (probably surprising and never documented, but this was the
Expand Down
Loading