Add flake8 B905 to extend-ignore in setup.cfg#4391
Merged
rwgk merged 2 commits intopybind:masterfrom Dec 9, 2022
Merged
Conversation
….pre-commit-config.yaml as-is on master.
--ignore=B905,N818,W503B905 to extend-ignore in setup.cfg
Collaborator
Author
|
I canceled the CI workflow to not burn so many cycles for a no-op. |
Skylion007
approved these changes
Dec 9, 2022
Collaborator
Author
|
Thanks Aaron! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I believe (but I'm not actually sure) that the recent flake8 dependabot upgrade from 5.0.4 to 6.0.0, combined with github switching ubuntu-latest from 20.04 to 22.04, is leading to these pre-commit failures:
This is one of the "Opinionated warnings" and for Python >= 3.10 only:
I.e. we cannot enable it until we drop 3.9 (https://endoflife.date/python for 3.9 is October 2025).
Suggested changelog entry: