[smart_holder] git merge master#4512
Merged
rwgk merged 8 commits intopybind:smart_holderfrom Feb 17, 2023
Merged
Conversation
* Always display python type information in cast errors * Address comments * Update comment
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
* Revert "Go back to CMake 3.25.2 (pybind#4496)" This reverts commit b8f2855. * Apply patch provided by @bradking (with pre-commit cmake-format auto fixes). pybind#4503 (comment)
…ng for a fix on master." This reverts commit 3cef809.
```
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
pybind11/setup_helpers.py:177:13: B028 No explicit stacklevel keyword argument found. The warn method from the warnings module uses a stacklevel of 1 by default. This will only show a stack trace for the line on which the warn method is called. It is therefore recommended to use a stacklevel of 2 or greater to provide more information to the user.
warnings.warn("You cannot safely change the cxx_level after setting it!")
^
```
Collaborator
Author
|
Google-global test ID: OCL:510256580:BASE:510359595:1676623238890:433bc022 (passed) |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Helper/scratch PR for testing.
Suggested changelog entry: