Skip to content

Warning on comparing wrapper enums with is #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Warning on comparing wrapper enums with is #4732

merged 3 commits into from
Jul 12, 2023

Conversation

lucmans
Copy link
Contributor

@lucmans lucmans commented Jul 7, 2023

Added warning to docs on comparing wrapped enums with "is", which is customary in Python.

@lucmans lucmans requested a review from rwgk July 11, 2023 14:16
@rwgk rwgk merged commit 6d22dba into pybind:master Jul 12, 2023
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 12, 2023
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants