fix: don't force -fvisibility=hidden on Windows #5757
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure is no related to this PR |
2 tasks
henryiii
changed the title
moi15moi
added a commit
to moi15moi/VideoTimestamps
that referenced
this pull request
Aug 22, 2025
The fix for msys2 is included in 3.0.1 (pybind/pybind11#5757)
moi15moi
added a commit
to moi15moi/VideoTimestamps
that referenced
this pull request
Aug 22, 2025
The fix for msys2 is included in 3.0.1 (pybind/pybind11#5757)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5750
Do you want me to add a msys2 (that use clang) into the workflow so these kind of problem are catched by the CI?
Description
This allow to compile on msys2 clang without any error.
Without this fix, I was getting the error:
hidden visibility cannot be applied to 'dllexport' declarationThis was probably affecting any environment of msys2, but I didn't verified.
Suggested changelog entry: