-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: rename generic slots variable #5793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fdb6195
to
1e2acd5
Compare
Signed-off-by: Henry Schreiner <[email protected]> style: pre-commit fixes
Signed-off-by: Henry Schreiner <[email protected]>
e61877b
to
ec27916
Compare
Getting this on 3.13t pretty often:
|
Yeah ... it used to be rare until about a month ago, but suddenly this particular test CI / 🐍 (macos-13, 3.13t, -DCMAKE_CXX_STANDARD=11) started failing very often. I don't know why, but I believe almost certainly this is unrelated to changes in pybind11. Maybe there was a Python 3.13 patch release? Or the macOS runners had some change? If nobody has time to drill down (I don't), maybe we should just disable those tests under macOS with free-threading? |
It wasn't quite a month ago, this was the first time I noticed, July 28, 2025: |
This is probably not enough to fix the original problem. |
That's in the cpython sources. There is nothing we can do about that, but I'd vote for merging @Henriii's changes, they make the naming better in general. |
You tagged the wrong henryiii, FYI :) |
Description
Fix #5788. Make it a bit easier to interface with Qt code. Qt's terrible macro names strike again.
Suggested changelog entry:
slots
(reads better)📚 Documentation preview 📚: https://pybind11--5793.org.readthedocs.build/