Skip to content

Fix buffer protocol inheritance #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2017
Merged

Conversation

dean0x7d
Copy link
Member

Fixes #878.

Resolved by looking for the first valid implementation of get_buffer in a types' MRO.

@wjakob
Copy link
Member

wjakob commented May 28, 2017

Good catch, this looks good.

@jagerman
Copy link
Member

👍

@dean0x7d dean0x7d merged commit 427e4af into pybind:master May 29, 2017
@dean0x7d dean0x7d deleted the inherit-buffer branch May 29, 2017 00:32
@dean0x7d dean0x7d modified the milestone: v2.2 Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants