Use PEP 518 pyproject.toml to require cffi

[segevfiner]

Using setup_requires triggers installation of cffi using the old and crusty easy_install, which often doesn't work well if at all.

PEP 518 allows specifiying this requirements in a pyproject.toml file, which pip 10 recognizes and will install those requirements itself.

[alex]

pyproject.toml only works with packages that are installed as wheels right now. Since cffi isn't always available as a wheel, we can't do this yet.

[segevfiner]

pyproject.toml only works with packages that are installed as wheels right now. Since cffi isn't always available as a wheel, we can't do this yet.

What do you mean? The latest pip installs everything as a wheel, if it can. If a wheel isn't available from PyPI, it builds a wheel first and installs that.

I think using pyproject.toml makes it build the wheel in a virtualenv containing only the specified packages.

Is there really a problem with this behavior?

[alex]

pip will not attempt to build a wheel for a dependency in pyproject.toml if there is only an sdist available.

[segevfiner]

pip will not attempt to build a wheel for a dependency in pyproject.toml if there is only an sdist available.

Arghh... you are right: pypa/pip#5229. That's rather lame on pip's part...

[alex]

I'm sure they'd be delighted for a patch to resolve this issue.

…

On Wed, Jul 11, 2018 at 8:24 AM Segev Finer ***@***.***> wrote: pip will not attempt to build a wheel for a dependency in pyproject.toml if there is only an sdist available. Arghh... you are right: pypa/pip#5229 <pypa/pip#5229>. That's rather lame on pip's part... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#453 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAADBM-YFviSfZ0enytC-XnBYSyaf3cdks5uFe5_gaJpZM4VKr7A> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[segevfiner]

A new version of pip was released where source installs from PEP 518 is now supported. (pypa/pip#5336). I didn't yet get to check if it works properly.

[reaperhulk]

#457 does this