Replace internal API _PyBytes_Join, removed in Python 3.13 #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I know that the
regex
package wrote a somewhat nontrivial replacement routine in mrabarnett/mrab-regex@bc73ebb, but this call happens only once at the end ofGzipReader_readall
, so I expect any added overhead should be negligible. Similarly, we could have used something likePyObject_CallMethodObjArgs
, but that would have required us to build aPyObject
containing the method name. In a quick test, I didn’t observe any change in the overall time required to run the test suite.Fixes #30.