Skip to content

Make installation process more robust for users #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2020

Conversation

qwhelan
Copy link
Collaborator

@qwhelan qwhelan commented Mar 23, 2020

Given our lack of wheels, installation is more complex than some other projects. Attempt to improve the user experience in a few ways:

  • Add dedicated installation page in documentation
  • Do a test compile to see if a compiler and/or Python development libraries are even available, and point users to installation page if not.
  • Add explicit Docker-based tests for minimum installation dependencies for a few OSes
  • Specify the C standard used when compiling under gcc=4.8 or lower, which is the default on RHEL/CentOS 7

cc #281

@codecov-io
Copy link

codecov-io commented Mar 23, 2020

Codecov Report

Merging #337 into master will decrease coverage by 0.23%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   85.32%   85.09%   -0.24%     
==========================================
  Files          29       29              
  Lines        3899     3911      +12     
  Branches      287      290       +3     
==========================================
+ Hits         3327     3328       +1     
- Misses        529      540      +11     
  Partials       43       43
Impacted Files Coverage Δ
bottleneck/src/bn_config.py 0% <0%> (ø) ⬆️
bottleneck/src/move_template.c 93.02% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2803873...7c05a2c. Read the comment docs.

@qwhelan qwhelan merged commit 44248f3 into pydata:master Mar 23, 2020
@qwhelan qwhelan deleted the robust_setup branch November 22, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants