Skip to content

Add one-dimensional advanced indexing for a single index. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2018

Conversation

hameerabbasi
Copy link
Collaborator

No description provided.

@hameerabbasi hameerabbasi requested review from mrocklin and shoyer July 25, 2018 16:55
@hameerabbasi
Copy link
Collaborator Author

@stsievert, @mrocklin, @shoyer If you're interested in reviewing and have time. :-)

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #172 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   97.14%   97.21%   +0.07%     
==========================================
  Files          11       11              
  Lines        1259     1291      +32     
==========================================
+ Hits         1223     1255      +32     
  Misses         36       36
Impacted Files Coverage Δ
sparse/utils.py 98.4% <100%> (ø) ⬆️
sparse/coo/indexing.py 99.18% <100%> (+0.27%) ⬆️
sparse/slicing.py 99.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb64a5...f091258. Read the comment docs.

@hameerabbasi hameerabbasi changed the title Add one-dimensional advanced indexing. Add one-dimensional advanced indexing for a single index. Jul 25, 2018
@hameerabbasi
Copy link
Collaborator Author

Waiting for a day and then merging in the absence of objections.

@hameerabbasi hameerabbasi merged commit 3e2821d into pydata:master Aug 1, 2018
@hameerabbasi hameerabbasi deleted the adv-idx branch October 22, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant