Skip to content

Slicing and advanced indexing for DOK #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Slicing and advanced indexing for DOK #458

wants to merge 2 commits into from

Conversation

sayandip18
Copy link
Contributor

Fixes #298

hameerabbasi
hameerabbasi reviewed Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we integrate this into the DOK type? I see some monkeypatching going on.

@sayandip18
Copy link
Contributor Author

Can we integrate this into the DOK type?

Do you mean including vix as a function in DOK?

@hameerabbasi
Copy link
Collaborator

Do you mean including vix as a function in DOK?

I mean as an property.

@sayandip18
Copy link
Contributor Author

Calling the function add_vector_indexer_to_sparse_dok() essentially does that. Maybe we can import and call the function in _dok.py which will give us the desired behaviour.

@hameerabbasi
Copy link
Collaborator

Calling the function add_vector_indexer_to_sparse_dok() essentially does that. Maybe we can import and call the function in _dok.py which will give us the desired behaviour.

I'd prefer for vix to be directly added to all DOK objects.

@hameerabbasi
Copy link
Collaborator

@sayandip18 Do you plan to continue this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hameerabbasi hameerabbasi hameerabbasi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for DOK slicing and advanced indexing
2 participants
@sayandip18 @hameerabbasi