Skip to content

Added warnings for NaN propagation #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2021
Merged

Added warnings for NaN propagation #469

merged 5 commits into from
Apr 25, 2021

Conversation

H4R5H1T-007
Copy link
Contributor

Fixes #340 with a warning for now.

@hameerabbasi
Copy link
Collaborator

You can run the benchmarks with asv run, check the docs for asv

hameerabbasi
hameerabbasi reviewed Apr 25, 2021
View reviewed changes
hameerabbasi
hameerabbasi reviewed Apr 25, 2021
View reviewed changes
@H4R5H1T-007
Copy link
Contributor Author 

All benchmarks:
       before           after         ratio
     [e036c254]       [318e6694]
     <master~2>       <master>  
      2.78±0.08ms      2.93±0.08ms     1.05  benchmark_coo.ElemwiseBroadcastingSuite.time_add
          361±2μs         376±10μs     1.04  benchmark_coo.ElemwiseBroadcastingSuite.time_mul
      3.42±0.03ms      3.67±0.07ms     1.07  benchmark_coo.ElemwiseSuite.time_add
         999±10μs      1.06±0.03ms     1.07  benchmark_coo.ElemwiseSuite.time_mul
          521±4μs          555±9μs     1.07  benchmark_coo.IndexingSuite.time_index_fancy
       26.1±0.1μs       27.3±0.4μs     1.05  benchmark_coo.IndexingSuite.time_index_scalar
          117±2μs          122±1μs     1.04  benchmark_coo.IndexingSuite.time_index_slice
         283±10μs          295±5μs     1.04  benchmark_coo.IndexingSuite.time_index_slice2
         299±10μs          307±2μs     1.03  benchmark_coo.IndexingSuite.time_index_slice3
         340±10μs         379±10μs    ~1.11  benchmark_coo.MatrixMultiplySuite.time_matmul
      4.72±0.04ms       5.02±0.1ms     1.06  benchmark_gcxs.ElemwiseBroadcastingSuite.time_add
      1.16±0.03ms      1.21±0.04ms     1.05  benchmark_gcxs.ElemwiseBroadcastingSuite.time_mul
       6.95±0.2ms      7.25±0.09ms     1.04  benchmark_gcxs.ElemwiseSuite.time_add
      3.14±0.04ms      3.33±0.07ms     1.06  benchmark_gcxs.ElemwiseSuite.time_mul
      1.57±0.02ms      1.68±0.01ms     1.07  benchmark_gcxs.IndexingSuite.time_index_fancy
          189±1μs          204±2μs     1.08  benchmark_gcxs.IndexingSuite.time_index_scalar
      1.56±0.03ms      1.65±0.02ms     1.06  benchmark_gcxs.IndexingSuite.time_index_slice
      1.03±0.01ms      1.10±0.03ms     1.07  benchmark_gcxs.IndexingSuite.time_index_slice2
         790±10μs         828±10μs     1.05  benchmark_gcxs.IndexingSuite.time_index_slice3
          342±3μs          369±6μs     1.08  benchmark_gcxs.MatrixMultiplySuite.time_matmul
          165±2ms          176±2ms     1.07  benchmark_tensordot.TensordotSuiteDenseSparse.time_dense
          165±2ms          176±4ms     1.06  benchmark_tensordot.TensordotSuiteDenseSparse.time_sparse
          134±2ms          146±6ms     1.09  benchmark_tensordot.TensordotSuiteSparseDense.time_dense
          134±2ms          145±4ms     1.09  benchmark_tensordot.TensordotSuiteSparseDense.time_sparse
         88.9±2ms         93.9±2ms     1.06  benchmark_tensordot.TensordotSuiteSparseSparse.time_dense
         88.3±2ms         92.8±1ms     1.05  benchmark_tensordot.TensordotSuiteSparseSparse.time_sparse

hameerabbasi
hameerabbasi requested changes Apr 25, 2021
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments.

hameerabbasi
hameerabbasi requested changes Apr 25, 2021
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final thing.

@H4R5H1T-007
Copy link
Contributor Author

Sir this is final benchmark.

All benchmarks:

       before           after         ratio
     [e036c254]       [4053ce4b]
     <master~4>       <master>  
      2.78±0.08ms       2.85±0.1ms     1.03  benchmark_coo.ElemwiseBroadcastingSuite.time_add
          361±2μs         377±20μs     1.04  benchmark_coo.ElemwiseBroadcastingSuite.time_mul
      3.42±0.03ms       3.55±0.1ms     1.04  benchmark_coo.ElemwiseSuite.time_add
         999±10μs      1.02±0.04ms     1.02  benchmark_coo.ElemwiseSuite.time_mul
          521±4μs          551±4μs     1.06  benchmark_coo.IndexingSuite.time_index_fancy
       26.1±0.1μs       27.5±0.3μs     1.05  benchmark_coo.IndexingSuite.time_index_scalar
          117±2μs          120±3μs     1.02  benchmark_coo.IndexingSuite.time_index_slice
         283±10μs          277±9μs     0.98  benchmark_coo.IndexingSuite.time_index_slice2
         299±10μs          295±5μs     0.99  benchmark_coo.IndexingSuite.time_index_slice3
         340±10μs         348±10μs     1.02  benchmark_coo.MatrixMultiplySuite.time_matmul
      4.72±0.04ms       4.86±0.2ms     1.03  benchmark_gcxs.ElemwiseBroadcastingSuite.time_add
      1.16±0.03ms      1.19±0.04ms     1.03  benchmark_gcxs.ElemwiseBroadcastingSuite.time_mul
       6.95±0.2ms       6.88±0.2ms     0.99  benchmark_gcxs.ElemwiseSuite.time_add
      3.14±0.04ms       3.18±0.1ms     1.01  benchmark_gcxs.ElemwiseSuite.time_mul
+     1.57±0.02ms       1.77±0.3ms     1.13  benchmark_gcxs.IndexingSuite.time_index_fancy
          189±1μs          201±5μs     1.06  benchmark_gcxs.IndexingSuite.time_index_scalar
      1.56±0.03ms      1.63±0.01ms     1.04  benchmark_gcxs.IndexingSuite.time_index_slice
      1.03±0.01ms      1.07±0.02ms     1.04  benchmark_gcxs.IndexingSuite.time_index_slice2
         790±10μs         834±90μs     1.06  benchmark_gcxs.IndexingSuite.time_index_slice3
          342±3μs          378±6μs    ~1.11  benchmark_gcxs.MatrixMultiplySuite.time_matmul
          165±2ms        174±0.9ms     1.05  benchmark_tensordot.TensordotSuiteDenseSparse.time_dense
          165±2ms        176±0.8ms     1.06  benchmark_tensordot.TensordotSuiteDenseSparse.time_sparse
          134±2ms          144±2ms     1.07  benchmark_tensordot.TensordotSuiteSparseDense.time_dense
          134±2ms          146±2ms     1.09  benchmark_tensordot.TensordotSuiteSparseDense.time_sparse
         88.9±2ms         93.6±2ms     1.05  benchmark_tensordot.TensordotSuiteSparseSparse.time_dense
         88.3±2ms         92.2±2ms     1.04  benchmark_tensordot.TensordotSuiteSparseSparse.time_sparse

hameerabbasi
hameerabbasi approved these changes Apr 25, 2021
View reviewed changes
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on CI.

@hameerabbasi hameerabbasi merged commit e64577e into pydata:master Apr 25, 2021
@hameerabbasi hameerabbasi mentioned this pull request Apr 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hameerabbasi hameerabbasi hameerabbasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nan propagation in matrix multiplication
2 participants
@H4R5H1T-007 @hameerabbasi