Conversation
|
I think the best option is backporting these PRs as they are blockers and real issues. |
|
I asked about it here: llvm/llvm-project#109135 (comment). But reshaping and adding Dense formats will stay broken until first 20 RC as it happens to be fixed in the current |
|
In that case we will need to build LLVM in CI (which is quite complicated) and it absolutely needs to be cached. |
CodSpeed Performance ReportMerging #787 will degrade performances by 32.04%Comparing Summary
Benchmarks breakdown
|
b15dd11 to
954996f
Compare
Right, in #799 I added caching with |
|
Closing in favour of #799. |
Hi @hameerabbasi,
This PR updates MLIR backend to current LLVM 20.dev (so
mainbranch) experimentally:formatattribute to Tensor class.tensor.emptycall link.As you can see it fixes a bunch of skips in the test suite: sparse/mlir_backend/tests/test_simple.py
It's thanks to changes already present in
mainbranch, added after19.xbranched, and:soaproperty tosparse_tensorPython bindings llvm/llvm-project#109135encodingargument totensor.emptyPython function llvm/llvm-project#110656test_output.pytest llvm/llvm-project#110882Maybe one thing that we can consider is to have a
nightlylabel for MLIR Python bindings feedstock some time in the future? Otherwise, I guess20.xwill branch in ~6months?