Skip to content

@requires_pinio mass disables unrelated tests #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crusaderky opened this issue Aug 28, 2017 · 3 comments · Fixed by #1557
Closed

@requires_pinio mass disables unrelated tests #1531

crusaderky opened this issue Aug 28, 2017 · 3 comments · Fixed by #1557

Comments

@crusaderky
Copy link
Contributor

I think I'm losing my sanity here.
I have a anaconda3 Python 3.6 environment with all required and optional dependencies of xarray installed and updated to the latest available version, except pyNio.
If I run test.py on the latest xarray package from the git tip, the vast majority of the tests in test_backends.py are skipped - including those that have nothing to do with pyNio!
e.g.

tests/test_backends.py::ScipyInMemoryDataTest::test_bytesio_pickle PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_coordinates_encoding SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_dataset_caching SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_dataset_compute SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_default_fill_value SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_encoding_kwarg SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_encoding_same_dtype SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_invalid_dataarray_names_raise SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_load SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_orthogonal_indexing PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_pickle SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_pickle_dataarray SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_None_variable SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_boolean_dtype SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_coordinates SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_datetime_data SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_endian SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_example_1_netcdf SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_float64_data SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_mask_and_scale SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_object_dtype SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_string_data SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_strings_with_fill_value SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_test_data SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_timedelta_data SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_to_netcdf_explicit_engine PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_unsigned_roundtrip_mask_and_scale SKIPPED
tests/test_backends.py::ScipyInMemoryDataTest::test_write_store PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_zero_dimensional_variable SKIPPED

If I comment out line 1462:

@requires_scipy 
# @requires_pynio 
class TestPyNio(CFEncodedDataTest, Only32BitTypes, TestCase):

Then magically everything starts working again!

tests/test_backends.py::ScipyInMemoryDataTest::test_bytesio_pickle PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_coordinates_encoding PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_dataset_caching PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_dataset_compute PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_default_fill_value PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_encoding_kwarg PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_encoding_same_dtype PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_invalid_dataarray_names_raise PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_load PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_orthogonal_indexing PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_pickle PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_pickle_dataarray PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_None_variable PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_boolean_dtype PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_coordinates PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_datetime_data PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_endian PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_example_1_netcdf PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_float64_data PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_mask_and_scale PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_object_dtype PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_string_data PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_strings_with_fill_value PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_test_data PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_roundtrip_timedelta_data PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_to_netcdf_explicit_engine PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_unsigned_roundtrip_mask_and_scale PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_write_store PASSED
tests/test_backends.py::ScipyInMemoryDataTest::test_zero_dimensional_variable PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_bytesio_pickle PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_coordinates_encoding PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_dataset_caching PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_dataset_compute PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_default_fill_value PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_encoding_kwarg PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_encoding_same_dtype PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_invalid_dataarray_names_raise PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_load PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_orthogonal_indexing PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_pickle PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_pickle_dataarray PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_None_variable PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_boolean_dtype PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_coordinates PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_datetime_data PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_endian PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_example_1_netcdf PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_float64_data PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_mask_and_scale PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_object_dtype PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_string_data PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_strings_with_fill_value PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_test_data PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_roundtrip_timedelta_data PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_to_netcdf_explicit_engine PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_unsigned_roundtrip_mask_and_scale PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_write_store PASSED
tests/test_backends.py::ScipyInMemoryDataTestAutocloseTrue::test_zero_dimensional_variable PASSED
@shoyer shoyer mentioned this issue Aug 29, 2017
Merged
4 tasks
@shoyer
Copy link
Member

shoyer commented Aug 29, 2017

Yes, this is surprising. I don't know why this is happening, but apparently it's not just happening to you (see @rabernat's complaint in #1528).

@rabernat
Copy link
Contributor

I discovered you can force the tests to run by doing e.g.

pytest -v xarray/tests/test_backends.py::ScipyInMemoryDataTest

Then they are not skipped. I don't know if this is a useful clue or not.

This was referenced Sep 7, 2017
Merged
Closed
@jhamman
Copy link
Member

jhamman commented Sep 7, 2017

likely bug reported in pytest-dev/pytest#2759

@jhamman jhamman mentioned this issue Feb 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix unintentional skipped tests
4 participants
@rabernat @shoyer @jhamman @crusaderky