Broken link to github on ReadTheDocs

[JiaweiZhuang]

The "Edit on GitHub" button on ReadTheDocs is linked to
https://github.com/pydata/xarray/blob/origin/stable/doc/index.rst
which doesn't exist. The correct URL would be without "origin":
https://github.com/pydata/xarray/blob/stable/doc/index.rst

[shoyer]

Thanks... I don't know if these links have ever worked properly for us. If anyone can figure out how to fix them, a PR would be appreciated!

[raybellwaves]

I started to have a look at this.

I needed to install rasterio to build the docs but unfortunately the conda installation isn't working (see conda-forge/rasterio-feedstock#53) nor is the pip installation (see rasterio/rasterio#1244).

Anyone who uses a Mac and mostly installs via conda have any advice installing rasterio?

[fmaussion]

I'm not sure it'll help, but have you tried creating the environment with the same pinned versions as we use for building the docs? i.e:

conda env create -n xarray-docs -f /path/to/xarray/doc/environment.yml

[shoyer]

I have also had trouble getting a rasterio build working on OS X.

To be honest, I have been commenting out the bit in the docs config that sets up sphinx gallery when testing locally:

xarray/doc/conf.py

Line 56 in 5a28b89

'sphinx_gallery.gen_gallery',

It would be nice if a lack of rasterio did not fail the docs build.

[shoyer]

It looks like expected_failing_examples would take care of it:
https://sphinx-gallery.github.io/advanced_configuration.html#don-t-fail-the-build-on-exit

[Zac-HD]

Related to readthedocs/readthedocs.org#1820, I think. Searching reveals that there have been a variety of problems with the 'Edit on Github' link over time.

[shoyer]

Interesting. Reading that link, I see that RTD now automatically creates the "stable" tag. I've still been pushing manually to a branch! I guess the problem manifests the same way, though.

…

On Fri, Feb 9, 2018 at 2:13 AM Zac Hatfield Dodds ***@***.***> wrote: Related to readthedocs/readthedocs.org#1820 <readthedocs/readthedocs.org#1820>, I think. Searching reveals that there have been a variety of problems with the 'Edit on Github' link over time. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1789 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKS1uBC9SqqiZy-cHQk5GJMezmvbSZiks5tTBpXgaJpZM4RFoQG> .

[dcherian]

The link works now.