fix: dask divide by zero error when empty dimensions are passed into partial autochunk spec - #11486
Open
charles-turner-1 wants to merge 5 commits into
Open
fix: dask divide by zero error when empty dimensions are passed into partial autochunk spec#11486charles-turner-1 wants to merge 5 commits into
charles-turner-1 wants to merge 5 commits into
Conversation
…nally fill in zero dimensions with auto - otherwise dask gives a(n avoidable) divide by zero error
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I discovered this whilst playing with charles-turner-1/xrexpr#121 (expression rewriting).
TLDR; auto-chunking on zero length dimensions fails, because dask divides by zero:
I've hidden the traceback in a detail block because it's pretty long.
Details
I haven't opened an issue for this - I could see a straightforward fix so I just got cracking on it, but I did have a look and I couldn't find any extant issues mentioning it. Happy to open one for clarity!
I also stuck the test right below the chunking tests in the dataarray section - not totally sure it's the best place for it, open to suggestions!
Checklist
whats-new.rstapi.rstN/AAI Disclosure