Repository navigation
BUG: Fix Dataset.argmax warning and error messages - #11723
Conversation
4d47c83 to
b7d55b9
Compare
headtr1ck
left a comment
There was a problem hiding this comment.
That test is not really useful, you can just drop it.
b7d55b9 to
5853eb7
Compare
|
Removed the message-specific test as requested and kept the PR focused on the implementation and release note. I amended the existing commit (5853eb7). Validation: the focused Dataset reduction tests pass (2 passed), and Ruff check/format plus |
|
CI follow-up: the minimum-versions job's only failure is an unrelated Zarr/Blosc decompression error in |
|
You can ignore the error, it's fixed in #11727 |
Co-authored-by: Claude <noreply@anthropic.com>
Description
Fix the
Dataset.argmax()deprecation warning and invalid-dimension error messages, which incorrectly referred toargminbecause of a copy-paste mistake. Add focused regression coverage for both messages.This addresses one small-cleanup item in #11721; it does not close the full tracking issue.
Checklist
whats-new.rstapi.rst— N/A; no API was added.AI Disclosure
Tools: OpenAI Codex
Prompt: Fix the issue-backed
Dataset.argmax()copy-paste message bug, add focused tests and a release note, and run relevant tests and lint.