Skip to content

raise TypeError in Variable.quantile if data is a dask array #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2017
Merged

raise TypeError in Variable.quantile if data is a dask array #1529

merged 3 commits into from
Aug 28, 2017

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Aug 28, 2017 •
edited
Loading

@jhamman jhamman mentioned this pull request Aug 28, 2017
Closed
shoyer
shoyer approved these changes Aug 28, 2017
View reviewed changes
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good lesson on why we need unit tests even for error messages :)

@jhamman jhamman merged commit 174bad0 into pydata:master Aug 28, 2017
leeviannala added a commit to leeviannala/xarray that referenced this pull request Aug 29, 2017
@leeviannala
Merge pull request #1 from pydata/master
2409601 
raise TypeError in Variable.quantile if data is a dask array (pydata#1529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhamman @shoyer