remove warning and raise error when dataset constructor is called wit…#1539
Merged
jhamman merged 3 commits intopydata:masterfrom Aug 31, 2017
jhamman:deprecate/dict_dims
Merged
remove warning and raise error when dataset constructor is called wit…#1539jhamman merged 3 commits intopydata:masterfrom jhamman:deprecate/dict_dims
jhamman merged 3 commits intopydata:masterfrom
jhamman:deprecate/dict_dims
Conversation
…h coords dict and not dims
shoyer
reviewed
Aug 31, 2017
xarray/core/dataarray.py
Outdated
| 'deprecated. Use an explicit list of ' | ||
| '``dims`` instead.') | ||
| else: | ||
| for n, (dim, coord) in enumerate(zip(dims, coords)): |
Member
There was a problem hiding this comment.
Can remove the else and dedent this clause now? (This is now the guard clause pattern.)
doc/whats-new.rst
Outdated
| ~~~~~~~~~~~~~~~~ | ||
|
|
||
| - Supplying ``coords`` as a dictionary to the ``DataArray`` constructor without | ||
| also supplying an explicit ``dims`` argument is no longer supported. (:issue:`727`). |
Member
There was a problem hiding this comment.
Say something like: was deprecated in version X but is now an error.
shoyer
approved these changes
Aug 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…h coords dict and not dims
git diff upstream/master | flake8 --diffwhats-new.rstfor all changes andapi.rstfor new API