Fix the test suite on dask 0.15.3 #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
force-pushed
the
fix-tests-dask0.15.3
branch
from
e46753d to
bd3eb96
Compare
shoyer
commented
Oct 5, 2017
| @@ -473,7 +476,6 @@ def test_from_dask_variable(self): | |||
| self.assertLazyAndIdentical(self.lazy_array, a) | |||
|
|
|||
|
|
|||
| @requires_dask | |||
| @pytest.mark.parametrize("method", ['load', 'compute']) | |||
There was a problem hiding this comment.
@jhamman For future reference, it looks like pytest.mark.parametrize doesn't play well with the unittest based skiptest decorator. So I switched the import check to use something different for this module, but it's something we'll have to watch out for in the future, too.
jhamman
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test suite is currently failing due to dask/dask#2718. This marks the failure as expected, which will make our CI a reliable indicator again.