Deprecate checking coordinates in DataArray.__contains__ #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, this should check array values. For now, add a deprecation warning. xref GH1267
This was referenced Oct 22, 2017
jhamman
approved these changes
Oct 22, 2017
| if self.dim in self.obj.coords: | ||
| concat_dim = self.window_labels | ||
| else: | ||
| concat_dim = self.dim |
There was a problem hiding this comment.
Was this the only place we were looking for coords in this way?
There was a problem hiding this comment.
There were a couple more. Verified by converting the warning into an error and running the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, this should check array values. For now, issue a FutureWarning.
git diff upstream/master | flake8 --diffwhats-new.rstfor all changes andapi.rstfor new API