Fix "Chunksize cannot exceed dimension size" #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GH1225
shoyer
force-pushed
the
encoding-bad-chunks
branch
from
589bb1a to
f5c1b57
Compare
jhamman
approved these changes
Nov 11, 2017
xarray/backends/netCDF4_.py
Outdated
| c > d for c, d in zip(encoding['chunksizes'], variable.shape)) | ||
| changed_shape = encoding.get('original_shape') != variable.shape | ||
| if chunks_too_big or changed_shape: | ||
| del encoding['chunksizes'] |
There was a problem hiding this comment.
this looks fine. Can you add a comment here that explains that we are dropping the encoding chunksizes so that netCDF4-python can write this dataset
jhamman
reviewed
Nov 11, 2017
xarray/backends/netCDF4_.py
Outdated
| del encoding['chunksizes'] | ||
| if not raise_on_invalid and 'chunksizes' in encoding: | ||
| chunks_too_big = any( | ||
| c > d for c, d in zip(encoding['chunksizes'], variable.shape)) |
There was a problem hiding this comment.
It looks like you'll need to make sure encoding['chunksizes'] is an iterable of length variable.ndim
|
I updated the logic to only drop |
jhamman
approved these changes
Nov 13, 2017
|
I had this error in 0.9.5. 0.10.0 definitely fixes it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master **/*py | flake8 --diffwhats-new.rstfor all changes andapi.rstfor new API