Skip to content

fix rasterio chunking with s3 datasets #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2018
Merged

fix rasterio chunking with s3 datasets #1817

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d31cff
fixes #1816
rabernat Jan 10, 2018
f123ab4
new and refactored rasterio tests
rabernat Jan 13, 2018
350b929
merge upstream/master
rabernat Jan 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion xarray/backends/rasterio_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,11 @@ def open_rasterio(filename, chunks=None, cache=None, lock=None):
if chunks is not None:
from dask.base import tokenize
# augment the token with the file modification time
mtime = os.path.getmtime(filename)
try:
mtime = os.path.getmtime(filename)
except FileNotFoundError:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 2 only has the super-class OSError, so that should probably be used instead here.

# the filename is probably and s3 bucket rather than a regular file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and -> an

mtime = None
token = tokenize(filename, mtime, chunks)
name_prefix = 'open_rasterio-%s' % token
if lock is None:
Expand Down