add warning stating that xarray will drop python 2 support at the end of 2018 #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
reviewed
Jan 31, 2018
doc/installing.rst
Outdated
| - `Xarray Github issue discussing dropping Python 2 <https://github.com/pydata/xarray/issues/1829>`__ | ||
| - `Python 3 Statement <http://www.python3statement.org/>`__ | ||
| - `Tips on porting to Python 3 <https://docs.python.org/3/howto/pyporting.html>`__ | ||
|
|
||
| - Python 2.7, 3.4, 3.5, or 3.6 |
There was a problem hiding this comment.
Instead of a warning, maybe this should be written as a footnote after 2.7? We can save the loud "Warning" for the release notes.
Also, can we say "plans to drop support" instead of "is dropping support"?
shoyer
approved these changes
Jan 31, 2018
fmaussion
approved these changes
Jan 31, 2018
There was a problem hiding this comment.
I would reformulate the statement slightly:
"Xarray plans to drop support for python 2.7 at the end of 2018. This means that new releases of xarray published after this date will only be installable on python 3+ environments, but older versions of xarray will always be available to python 2.7 users. For more information see ..."
doc/whats-new.rst
Outdated
| @@ -13,6 +13,15 @@ What's New | |||
| import xarray as xr | |||
| np.random.seed(123456) | |||
|
|
|||
| .. warning:: | |||
|
|
|||
| Xarray plans to drop support at the end of 2018. For more information see | |||
doc/installing.rst
Outdated
| @@ -96,3 +96,10 @@ To run these benchmark tests in a local machine, first install | |||
|
|
|||
| and run | |||
| ``asv run # this will install some conda environments in ./.asv/envs`` | |||
|
|
|||
| .. [1] Xarray plans to drop support at the end of 2018. For more | |||
|
Looks good to me, thanks @jhamman and @fmaussion ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstfor all changes andapi.rstfor new API